8000 No longer connect to idle event on wx. by anntzer · Pull Request #8722 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

No longer connect to idle event on wx. #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017
Merged

No longer connect to idle event on wx. #8722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
No longer connect to idle event on wx.
  • Loading branch information
@anntzer
anntzer committed Jun 14, 2017
commit f6dd3b037c1e2d8e2394132cce7ec4bc13cde695
7 changes: 7 additions & 0 deletions doc/api/api_changes/2017-06-06-AL_wxidle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
WX no longer calls generates ``IdleEvent`` events or calls ``idle_event``
`````````````````````````````````````````````````````````````````````````

Removed unused private method ``_onIdle`` from ``FigureCanvasWx``.

The ``IdleEvent`` class and ``FigureCanvasBase.idle_event`` method
will be removed in 2.2
6 changes: 0 additions & 6 deletions lib/matplotlib/backends/backend_wx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,6 @@ def do_nothing(*args, **kwargs):
self.Bind(wx.EVT_MOTION, self._onMotion)
self.Bind(wx.EVT_LEAVE_WINDOW, self._onLeave)
self.Bind(wx.EVT_ENTER_WINDOW, self._onEnter)
self.Bind(wx.EVT_IDLE, self._onIdle)
# Add middle button events
self.Bind(wx.EVT_MIDDLE_DOWN, self._onMiddleButtonDown)
self.Bind(wx.EVT_MIDDLE_DCLICK, self._onMiddleButtonDClick)
Expand Down Expand Up @@ -1007,11 +1006,6 @@ def _get_key(self, evt):

return key

def _onIdle(self, evt):
'a GUI idle event'
evt.Skip()
FigureCanvasBase.idle_event(self, guiEvent=evt)

def _onKeyDown(self, evt):
"""Capture key press."""
key = self._get_key(evt)
Expand Down
3 changes: 0 additions & 3 deletions lib/matplotlib/tests/test_backends_interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
# PyPI-installable on Travis. They are not available for all tested Python
# versions so we don't fail on missing backends.
#
# Once the Travis build environment switches to Ubuntu 14.04, we should be able
# to add wxagg (which has wheels for 14.04 but not for 12.04).
#
# We also don't test on Py2 because its subprocess module doesn't support
# timeouts, and it would require a separate code path to check for module
# existence without actually trying to import the module (which may install
Expand Down
0