8000 Fix skipif in interactive backends test. by anntzer · Pull Request #8691 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix skipif in interactive backends test. #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2017
Merged

Fix skipif in interactive backends test. #8691

merged 1 commit into from
May 31, 2017

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 31, 2017 •
edited
Loading

See discussion at #8679.

@matthew-brett
Copy link
Contributor

From discussion and testing over at #8679 - looks good to me.

@tacaswell
Copy link
Member

I am going with we are not super concerned about how pytest decorators interact with each other, possibly as a function of pytest version.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 31, 2017
@QuLogic
Copy link
Member
QuLogic commented May 31, 2017 •
edited
Loading

I'd guess this might have something to do with the new pytest.param setup (see last example) they've recently added in 3.1.

@QuLogic QuLogic merged commit 6dd935b into matplotlib:master May 31, 2017
@anntzer anntzer deleted the fix-interactive-backends-testing branch May 31, 2017 21:54
@anntzer anntzer mentioned this pull request Jun 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @matthew-brett @tacaswell @QuLogic
0