8000 Document 'right' legend position as alias for 'center right'. by anntzer · Pull Request #8666 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Document 'right' legend position as alias for 'center right'. #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2017
Merged

Document 'right' legend position as alias for 'center right'. #8666

merged 1 commit into from
May 26, 2017

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 26, 2017

Closes #8464.

@dstansby
Copy link
Member

I think this needs changing in lib/matplotlib/offsetbox.py too:

$ grep -r "'right'        : 5," lib/matplotlib
lib/matplotlib/offsetbox.py:        'right'        : 5,
lib/matplotlib/legend.py:      'right'        : 5,

@anntzer anntzer force-pushed the document-legend-right branch from 705c7a5 to 7a776f1 Compare May 26, 2017 15:38
@anntzer
Copy link
Contributor Author
anntzer commented May 26, 2017

done, tweaked the message to fit within 79 chars in both cases.

dstansby
dstansby approved these changes May 26, 2017
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if doc builds pass

@QuLogic QuLogic added this to the 2.1 (next point release) milestone May 26, 2017
@QuLogic QuLogic merged commit 1144e8c into matplotlib:master May 26, 2017
@anntzer anntzer deleted the document-legend-right branch May 26, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @QuLogic
0