Ignore non-finite vertices when running count_contains #8651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reproduce the original issue, and I think the correct fix, if any, would be to manipulate the numpy errstate before the comparison is done. |
|
I agree with @anntzer that this would be better handled by modifying the error state of numpy rather than pre-filtering. |
|
@dstansby can you please provide a repro for the original issue? I still don't see why this patch is even needed (and, if it is needed, I would guess that the errstate probably needs to be adjusted at a gazillion other places as well). |
|
There's a minimal example in the original issue.
…On 26 May 2017 7:13 am, "Antony Lee" ***@***.***> wrote:
@dstansby <https://github.com/dstansby> can you please provide a repro
for the original issue? I still don't see why this patch is even needed
(and, if it is needed, I would guess that the errstate probably needs to be
adjusted at a gazillion other places as well).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8651 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6RfEG9zJsokk5BQyr6IRqQr6I7v2TCks5r9m2BgaJpZM4NhnB9>
.
|
|
Ah, sorry, I missed the fact that this was only on master. In fact I'm the culprit... c2aabe9 incorrectly removed the errstate manipulation. |
anntzer
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding whether vertices are in a given bounding box, ignore non-finite vertices (ie.
np.nanvalues). The avoids a spurious warning being raised. Fixes #8611.