Add pandas to python 3.6 build #8584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
May 7, 2017
|
@tacaswell how large is the overhead. As I recall (but I could be wrong) the main overhead originally was from building pandas. Now that we have bin wheels and pip caching that should be minimal so it's only really the runtime overhead of the tests |
|
@jenshnielsen Ah, good point. There are only a handful of tests so this should not affect runtime that much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason why we shouldn't do pandas tests on the python 3.6 build, especially now we have a nice tutorial about plotting with pandas data!