added basic_units download link to units examples #8554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobson
approved these changes
May 1, 2017
choldgraf
reviewed
May 1, 2017
| @@ -1,5 +1,7 @@ | |||
| .. _units_examples: | |||
|
|
|||
| .. _units-examples-index: | |||
There was a problem hiding this comment.
just FYI - sphinx gallery will auto-create these labels when it builds the docs. They follow the convention .. _sphx_glr_path_to_file.py:
There was a problem hiding this comment.
(ack NVM, I think I am wrong. These labels only get generated for the .py files converted to RST, not the README.txt files)
|
I think this is a good addition to the PR so it's def worth merging in. That said, I think this section of examples might be a good candidate for converting to a tutorial on units in matplotlib in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added download link for basic_units.py to all units examples that require it. Also fixed cross-reference in bar-unit-demo - which tangentially I think should be deprecated since it seems clunky relative to the other bar example.
Here's a screenshot:
PR Checklist