8000 Give wide code blocks a scrollbar on website by dstansby · Pull Request #8339 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Give wide code blocks a scrollbar on website #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

dstansby
Copy link
Member

Fixes #8153

@NelleV
Copy link
Member
NelleV commented Mar 19, 2017

I don't think this is the approriate fix.

@dstansby
Copy link
Member Author

The git example is one area where this happens; I'll be there's a few others, and 99% of the time code never overruns the box. When it does I think having a scrollable box is way better than lines running off into the sidebar!

@NelleV
Copy link
Member
NelleV commented Mar 19, 2017

IMO, those places should be fixed individually by following good practices, not by adding a scrollbar (which is really not a good usability solution).

I won't approve this PR but I am not blocking it either.

@anntzer
Copy link
Contributor
anntzer commented Mar 20, 2017

You should use auto instead of scroll so that only the few boxes that need it get a scrollbar.

I agree that we should try as much as possible to get rid of overly wide boxes, but 1. it's not so easy to check them (AFAICT) and 2. you never know what the window width of the reader is.

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Apr 4, 2017
@anntzer anntzer merged commit 7e4f01a into matplotlib:master Apr 5, 2017
@anntzer
Copy link
Contributor
anntzer commented Apr 5, 2017

thanks!

@dstansby dstansby deleted the overflowing-code branch April 6, 2017 07:05
tacaswell pushed a commit that referenced this pull request Apr 14, 2017
Give wide code blocks a scrollbar on website
@tacaswell
Copy link
Member

backported to v2.0.0-doc as fa76580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0