10000 DOC shapes and collections is fully SG compatible by NelleV · Pull Request #8310 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC shapes and collections is fully SG compatible #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2017
Merged

DOC shapes and collections is fully SG compatible #8310

merged 1 commit into from
Mar 17, 2017

Conversation

NelleV
Copy link
Member
@NelleV NelleV commented Mar 16, 2017

This is the last part to make the folder shapes and collection fully sphinx-gallery compatible.

@NelleV NelleV changed the title DOC shapes and collections is fully SG compatible [MRG] DOC shapes and collections is fully SG compatible Mar 16, 2017
@NelleV NelleV added Documentation MEP: MEP12 gallery and examples improvements labels Mar 16, 2017
@@ -2,6 +2,9 @@
================
PathPatch object
================

This example shows how to create Paths and PathPatch objects through
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks for cross-references? (Does that work here?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks might work automatically for cross references. There's unfortunately no easy way to check this just yet, but we'll see once I merge this branch into the sphinx-gallery branch.

@@ -2,6 +2,9 @@
================
PathPatch object
================

This example shows how to create `Path`\s and `PathPatch` objects through
Matplotlib's API.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need blank lines around this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the question. If you are asking about the need for blanklines around """, then the answer is no.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sweet 👍

@phobson phobson changed the title [MRG] DOC shapes and collections is fully SG compatible [MRG+1] DOC shapes and collections is fully SG compatible Mar 17, 2017
@anntzer anntzer merged commit a46b3ed into matplotlib:master Mar 17, 2017
@anntzer
Copy link
Contributor
anntzer commented Mar 17, 2017

Thanks!

@anntzer anntzer changed the title [MRG+1] DOC shapes and collections is fully SG compatible DOC shapes and collections is fully SG compatible Mar 17, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Mar 17, 2017
@NelleV NelleV deleted the MEP12_shapes_and_collections branch March 19, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0