-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add errorbars to mplot3d #8031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add errorbars to mplot3d #8031
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
66cbdf6
add minimal errorbar3d method to Axes3D
vlas-sokolov d8e4d57
for now it's wiser to rely on LineCollection styling
vlas-sokolov 2d32dfe
type in autorange
vlas-sokolov 8e66193
fix for auto-scaling NaN values
vlas-sokolov d377942
add caplines
vlas-sokolov 9b1de1f
add barsabove option; refactor plotting kwargs
vlas-sokolov c7fc68a
fix for missing zorder in kwargs
vlas-sokolov ef5699c
add upper/lower limits
vlas-sokolov d4f67c2
add extended formatting from the 2d case; clean-up
vlas-sokolov 3b3e5d4
pep8 edits
vlas-sokolov 6889a3d
fix errorevery; return a container of sorts
vlas-sokolov 20f0caf
allow offsets for errorevery
vlas-sokolov cd63593
arrrr pep8 again
vlas-sokolov fb2d200
docstring edits
vlas-sokolov 74f5209
add example; update what's new section
vlas-sokolov 82dec2b
please just squash everything - I can't pep8 properly
vlas-sokolov c570c69
vim adds a newline behind the scenes already
vlas-sokolov c30c276
rebase against current master + fix dropped deprecations
f5ef8bd
fix compatibility issues with 2d errorbar version (WIP)
c3fa542
fix flake8 warnings, mirror naming/docstring style of other examples
b86260a
fix failing sphinx docs
45cbc81
add an image comparison unit test for 3d errorbars
42c1d27
errline gets drawn when both limits are set (compat. reasons)
5969893
refactor to use art3d.get_dir_vector instead of np.roll
26a4226
adapt 2d errorbar containers for legend handling
c8f1161
need to consider everymask for altering upper=lower limits
e18713a
switch to plt.quiver for drawling arrows
159b6b5
refactor numpy array handling
5db6976
allow for (2, N)-shaped errorbar input + small numpy refactors
3c7c0de
add numpy refactor as per PR suggestion
vlas-sokolov 3a99be8
add numpy refactror for errorbar3d example
vlas-sokolov 1a6f58a
add numpy refactor for errorbar3d unit test
05f4776
Merge branch 'master' into errorbars-mplot3d
vlas-sokolov 0d8c3e3
port most of the changes done in #15037 for 2d errorbars
93c9de5
Apply suggestions from code review
vlas-sokolov 1c73204
fix more pr comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rebase against current master + fix dropped deprecations
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, can you add
*, label=None
to the signature? Or is there a deliberate reason to not list this in the argument list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the reason is that 2d
ax.errorbar
was written for Python2, where that signature would throw aSyntaxError
. I made this PR taking the following comment from #568 - "just mirror ax.errorbar as closely as possible" as a guideline (reviewing its source side-by-side might be easier to show what bits are actually new in this PR). Should I still change it?