10000 Remove `sharex_foreign` example, now useless. by anntzer · Pull Request #7949 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Remove sharex_foreign example, now useless. #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 25, 2017

sharex_foreign has been removed in 2007 (0db017f).

`sharex_foreign` has been removed in 2007 (0db017f).
@NelleV
Copy link
Member
NelleV commented Jan 26, 2017

how the heck is that even possible?

@QuLogic QuLogic changed the title Remove sharex_foreign example, now useless. [MRG+1] Remove sharex_foreign example, now useless. Jan 26, 2017
@NelleV NelleV merged commit 7b79174 into matplotlib:master Jan 26, 2017
@NelleV
Copy link
Member
NelleV commented Jan 26, 2017

I didn't wait for the build to finish, which may have been a mistake if the documentation doesn't build anymore…

@QuLogic
Copy link
Member
QuLogic commented Jan 26, 2017

I think it just does nothing extra now; the old methods are commented out.

@anntzer anntzer deleted the remove-old-example branch January 26, 2017 00:58
@QuLogic QuLogic changed the title [MRG+1] Remove sharex_foreign example, now useless. Remove sharex_foreign example, now useless. Jan 26, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0