8000 Convert test_s* files to pytest and flake8 them by QuLogic · Pull Request #7918 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Convert test_s* files to pytest and flake8 them #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2017
Merged

Convert test_s* files to pytest and flake8 them #7918

merged 2 commits into from
Jan 23, 2017

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jan 22, 2017

This might be mostly flake8 in the end, but what's done is done now (though I could split the PRs if necessary.)

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 22, 2017
NelleV
NelleV approved these changes Jan 22, 2017
View reviewed changes
Copy link
Member
@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wouldn't do too much clean up on files that are likely to be modified in other PRs, as this may yield conflicts quite annoying to resolve.

@NelleV NelleV changed the title Convert test_s* files to pytest and flake8 them [MRG+1] Convert test_s* files to pytest and flake8 them Jan 22, 2017
@codecov-io
Copy link

Current coverage is 62.18% (diff: 100%)

Merging #7918 into master will decrease coverage by <.01%

@@             master      #7918   diff @@
==========================================
  Files           175        175          
  Lines         56125      56125          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          34901      34899     -2   
- Misses        21224      21226     +2   
  Partials          0          0

Powered by Codecov. Last update f41ef96...72807ab

@phobson phobson merged commit bb4d920 into matplotlib:master Jan 23, 2017
@phobson phobson changed the title [MRG+1] Convert test_s* files to pytest and flake8 them Convert test_s* files to pytest and flake8 them Jan 23, 2017
@QuLogic QuLogic deleted the pytest-s-modules branch January 23, 2017 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@phobson phobson phobson approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @codecov-io @NelleV @phobson
0