E533 DOC MEP12: pie/polar and color examples + style sheets fix by naoyak · Pull Request #7900 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@naoyak
Copy link
Contributor
@naoyak naoyak commented Jan 20, 2017

Ref: #7206

Also some small changes from #7890 which didn't make it in before merge

"""
======================================
Colors in the default property cycle
======================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the same length as text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually can be longer, but not shorter than the text, so this will compile fine.

for ax in axes:
ax.set_axis_off()

return axes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used for anything; why bother?

import matplotlib.pyplot as plt
from matplotlib import colors as mcolors


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove; two blank lines after imports.

@naoyak naoyak changed the title DOC MEP12: pie/polar charts and color examples [MRG] DOC MEP12: pie/polar charts and color examples Jan 21, 2017

fig, axs = plt.subplots(nrows=2, ncols=2, sharex=True, sharey=True)
for icol in range(2):
for icol in np.arange(2):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be changed.

@naoyak naoyak changed the title [MRG] DOC MEP12: pie/polar charts and color examples [MRG] DOC MEP12: pie/polar and color examples + style sheets fix Jan 21, 2017
@codecov-io
Copy link
codecov-io commented Jan 21, 2017

Current coverage is 62.17% (diff: 100%)

Merging #7900 into master will increase coverage by <.01%

@@             master      #7900   diff @@
==========================================
  Files           174        174          
  Lines         56121      56121          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34893      34896     +3   
+ Misses        21228      21225     -3   
  Partials          0          0          

Powered by Codecov. Last update 59478d2...cfb368a

@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Jan 21, 2017
@QuLogic QuLogic changed the title [MRG] DOC MEP12: pie/polar and color examples + style sheets fix [MRG+1] DOC MEP12: pie/polar and color examples + style sheets fix Jan 21, 2017
Copy link
Member
@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NelleV NelleV merged commit 60cd171 into matplotlib:master Jan 22, 2017
@NelleV
Copy link
Member
NelleV commented Jan 22, 2017

Thanks @naoyak

@naoyak naoyak deleted the mep12-pie-polar branch January 23, 2017 04:32
@QuLogic
Copy link
Member
QuLogic commented Jan 30, 2017

Backported to v2.0.0-doc as 9ac3003.

@QuLogic QuLogic changed the title [MRG+1] DOC MEP12: pie/polar and color examples + style sheets fix DOC MEP12: pie/polar and color examples + style sheets fix Jan 30, 2017
QuLogic pushed a commit that referenced this pull request Jan 30, 2017
DOC MEP12: pie/polar and color examples + style sheets fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0