8000 MAINT moved all remaining "f" modules to pytest by NelleV · Pull Request #7897 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MAINT moved all remaining "f" modules to pytest #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2017
Merged

MAINT moved all remaining "f" modules to pytest #7897

merged 2 commits into from
Jan 23, 2017

Conversation

NelleV
Copy link
Member
@NelleV NelleV commented Jan 20, 2017

This PR migrates the modules starting by "f" from nosetests to pytest.
It also does minor flake8 clean ups.

phobson
phobson approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member
@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phobson phobson changed the title MAINT moved all remaining "f" modules to pytest [MRG+1] MAINT moved all remaining "f" modules to pytest Jan 21, 2017
@phobson phobson added this to the 2.1 (next point release) milestone Jan 22, 2017
QuLogic
QuLogic reviewed Jan 22, 2017
View reviewed changes
lib/matplotlib/tests/test_figure.py
@@ -1,10 +1,9 @@
from __future__ import (absolute_import, division, print_function,
unicode_literals)

import six
from six.moves import xrange
Copy link
Member
@QuLogic QuLogic Jan 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this xrange too, while you're cleaning up things; there's only one of them.

@codecov-io
Copy link

Current coverage is 62.18% (diff: 100%)

Merging #7897 into master will increase coverage by <.01%

@@             master      #7897   diff @@
==========================================
  Files           174        175     +1   
  Lines         56121      56125     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34896      34901     +5   
+ Misses        21225      21224     -1   
  Partials          0          0

Powered by Codecov. Last update 194afed...3a96dbc

@jkseppan jkseppan changed the title [MRG+1] MAINT moved all remaining "f" modules to pytest MAINT moved all remaining "f" modules to pytest Jan 23, 2017
@jkseppan jkseppan merged commit 6bbf92c into matplotlib:master Jan 23, 2017
@NelleV NelleV deleted the pytest_f_modules branch January 29, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@phobson phobson phobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@NelleV @codecov-io @QuLogic @phobson @jkseppan
0