8000 Convert mpl toolkits tests to pytest + minor cleanup by QuLogic · Pull Request #7887 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Convert mpl toolkits tests to pytest + minor cleanup #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2017
Merged

Convert mpl toolkits tests to pytest + minor cleanup #7887

merged 2 commits into from
Jan 23, 2017

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jan 20, 2017

Besides the pytest stuff, drop unnecessary setup and testing functions.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 20, 2017
@NelleV NelleV changed the title Convert mpl toolkits tests to pytest + minor cleanup [MRG+1] Convert mpl toolkits tests to pytest + minor cleanup Jan 20, 2017
@jkseppan
Copy link
Member

Does the AppVeyor failure mean you should remove mpl_toolkits.tests.test_mplot3d from default_test_modules in lib/matplotlib/__init__.py?

@QuLogic
Copy link
Member Author
QuLogic commented Jan 20, 2017

Yes, I believe so; I didn't realize those builds don't install pytest at all. Though it doesn't technically break the nose build if it were installed, I'll just remove them from the list.

@QuLogic
Convert mpl_toolkits tests to pytest.
0e57a0b
@QuLogic
Remove unnecessary init from mpl_toolkits tests.
af79d51 
The setup is a) not done for normal matplotlib tests and b) mostly
implemented in the image_comparison decorator.
@QuLogic QuLogic force-pushed the pytest-mpl_toolkits branch from a3b2982 to af79d51 Compare January 20, 2017 22:05
@phobson phobson merged commit aabb6e8 into matplotlib:master Jan 23, 2017
@phobson phobson changed the title [MRG+1] Convert mpl toolkits tests to pytest + minor cleanup Convert mpl toolkits tests to pytest + minor cleanup Jan 23, 2017
@QuLogic QuLogic deleted the pytest-mpl_toolkits branch January 23, 2017 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@phobson phobson phobson approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit topic: testing
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @jkseppan @NelleV @phobson
0