8000 Use backports.functools_lru_cache instead of functools32 by felixonmars · Pull Request #7871 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Use backports.functools_lru_cache instead of functools32 #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2017
Merged

Use backports.functools_lru_cache instead of functools32 #7871

merged 1 commit into from
Feb 16, 2017

Conversation

felixonmars
Copy link
Contributor

It's better maintained and more widely used (by pylint, jaraco, etc).

@QuLogic QuLogic requested a review from mdboom January 19, 2017 21:59
@anntzer anntzer mentioned this pull request Jan 20, 2017
Closed
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jan 20, 2017
@tacaswell
Copy link
Member

I am mixed on this. A bit worried that changing the deps is going to just cause havoc for down-stream packagers as this is a new for 2.0 dependency, but sympathetic to using a more widely used / better maintained backport.

@felixonmars
Copy link
Contributor Author

I guess the havoc would be limited, since most distros have pylint packaged, they will have backports.functools_lru_cache already :)

@anntzer
Copy link
Contributor
anntzer commented Jan 23, 2017

Apparently pylint only started depending on backports.functools_lru_cache recently (pylint-dev/pylint@02f6823). For example, a quick search on pkgs.org suggests that none of CentOS, Debian Jessie, Mageia and Ubuntu (in their latest versions) provide that package right now.

@HolgerPeters
Copy link
Contributor

Not a linux distributor, but I bundle packages nonetheless and https://pypi.python.org/pypi/backports.functools_lru_cache seems to be a more mature package on a quick glance.

@NelleV
Copy link
Member
NelleV commented Jan 25, 2017

I am fine either way. @tacaswell I think you should be the one making the decision on this change, as you are the maintainer 😈

@tacaswell
Copy link
Member

I am 👍 on this for 2.1. Can you also put a file in https://github.com/matplotlib/matplotlib/tree/master/doc/api/api_changes with basically the first message from this PR?

tacaswell
tacaswell approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo and api_changes entry.

@felixonmars
Use backports.functools_lru_cache instead of functools32
460e19d 
It's better maintained and more widely used (by pylint, jaraco, etc).
@felixonmars felixonmars force-pushed the backports.functools_lru_cache branch from bf9d9a9 to 460e19d Compare January 31, 2017 00:57
@felixonmars
Copy link
Contributor Author

API changes file added :)

@felixonmars
Copy link
Contributor Author

Hrm, the test failure looks irrelevant.

@NelleV NelleV merged commit 4cfbb2f into matplotlib:master Feb 16, 2017
@NelleV
Copy link
Member
NelleV commented Feb 16, 2017

Thanks @felixonmars !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@mdboom mdboom Awaiting requested review from mdboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@felixonmars @tacaswell @anntzer @HolgerPeters @NelleV
0