8000 Add rcsetup_api.rst, fix typo for rcsetup.cycler by petehuang · Pull Request #7732 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@petehuang
Copy link
Contributor

Addresses #7223

dopplershift
dopplershift approved these changes Jan 3, 2017
@tacaswell tacaswell requested review from WeatherGod and tacaswell and removed request for tacaswell January 3, 2017 17:52
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that minor sphinx fix. (Other test failures look unrelated.)

@@ -0,0 +1,12 @@
*****
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The length of the **** needs to match that of rcsetup; that's causing a warning from sphinx.

cyl(label1=itr1[, label2=itr2[, ...]])
cyler(arg)
cyler(label, itr)
cyler(label1=itr1[, label2=itr2[, ...]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still has a typo. cyl was the original name, but then we decided it was ok to collide with the cycler from the cycler package.

8000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, can you clarify what you mean by still having a typo? What's the exact?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyler should be cycler

@petehuang
Copy link
Contributor Author

Ugh...bozo mistakes. I looked at cyler for like 15 minutes and still couldn't figure it out ☹️

@WeatherGod
Copy link
Member
WeatherGod commented Jan 4, 2017 via email

@codecov-io
Copy link
codecov-io commented Jan 4, 2017

Current coverage is 62.12% (diff: 100%)

Merging #7732 into master will not change coverage

@@             master      #7732   diff @@
==========================================
  Files           174        174          
  Lines         56028      56028          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34805      34805          
  Misses        21223      21223          
  Partials          0          0          

Powered by Codecov. Last update 8279f64...70d4546

@WeatherGod WeatherGod merged commit 015d8d5 into matplotlib:master Jan 4, 2017
WeatherGod added a commit that referenced this pull request Jan 4, 2017
< 8000 div class="d-flex flex-auto">
Add rcsetup_api.rst, fix typo for rcsetup.cycler
@WeatherGod
Copy link
Member

backported to v2.x branch via 3b48809

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0