-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Add bug report reqs and template to contributing guide #7701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm 50%-50% on this patch: it duplicates a lot of elements which we already have on our ticket page: https://github.com/matplotlib/matplotlib/issues/new Could we have all of this in a single place? In terms of content, it looks good to me. |
Oops, wasn't aware of the pre-loaded template on the new issue page. Let's definitely sync from both ends. Is there any place that template can be changed? |
You can find it here |
|
||
4. The expected outcome of the code snippet | ||
|
||
5. The matplotlib version, python version and platform that you are using. You can grab the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efiring @tacaswell So should matplotlib be capitalized here?
|
||
Thank you for your help in keeping bug reports complete, targeted and descriptive. | ||
|
||
Submitting a feature request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove this section. I don't think it is very useful and has a lot of duplication with the previous section. I think we need to keep the contributing guideline short.
@@ -14,8 +14,60 @@ Submitting a bug report | |||
|
|||
If you find a bug in the code or documentation, do not hesitate to submit a | |||
ticket to the | |||
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are | |||
also welcome to post feature requests or pull requests. | |||
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. |
**Expected outcome** | ||
|
||
- [ ] A description of the expected outcome from the code snippet | ||
- [ ] If this used to work in an earlier version of Matplotlib, please note where it used to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"please note the version it used to work on?"
- [ ] If this is a regression (Used to work in an earlier version of Matplotlib), please | ||
note where it used to work. | ||
|
||
###Feature request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove this section. We want to keep this as simple and short as possible.
On 2016/12/30 9:29 PM, Nelle Varoquaux wrote:
+ 5. The matplotlib version, python version and platform that you are using. You can grab the
@efiring <https://github.com/efiring> @tacaswell
<https://github.com/tacaswell> So should matplotlib be capitalized here?
I would say "yes", but this is one of those places where it is perfectly
acceptable to me either way.
|
@@ -14,9 +14,34 @@ Submitting a bug report | |||
|
|||
If you find a bug in the code or documentation, do not hesitate to submit a | |||
ticket to the | |||
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are | |||
also welcome to post feature requests or pull requests. | |||
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are also welcome to post feature requests or pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap at 80 here too.
LGTM 👍 |
Hopefully this doesn't conflict with #7699 at all (it shouldn't).
This adds a few recommendations for information to include when submitting bug reports. It also provides a Markdown-formatted template for anyone who wants to neatly organize their information in their issue.