8000 DOC: Add bug report reqs and template to contributing guide by petehuang · Pull Request #7701 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC: Add bug report reqs and template to contributing guide #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2017
Merged

DOC: Add bug report reqs and template to contributing guide #7701

merged 3 commits into from
Jan 2, 2017

Conversation

petehuang
Copy link
Contributor

Hopefully this doesn't conflict with #7699 at all (it shouldn't).

This adds a few recommendations for information to include when submitting bug reports. It also provides a Markdown-formatted template for anyone who wants to neatly organize their information in their issue.

@NelleV
Copy link
Member
NelleV commented Dec 30, 2016

I'm 50%-50% on this patch: it duplicates a lot of elements which we already have on our ticket page: https://github.com/matplotlib/matplotlib/issues/new

Could we have all of this in a single place?

In terms of content, it looks good to me.

@petehuang
Copy link
Contributor Author

Oops, wasn't aware of the pre-loaded template on the new issue page. Let's definitely sync from both ends. Is there any place that template can be changed?

@NelleV
Copy link
Member
NelleV commented Dec 30, 2016

You can find it here .github/ISSUE_TEMPLATE.md
I think it needs a bit of love :)


4. The expected outcome of the code snippet

5. The matplotlib version, python version and platform that you are using. You can grab the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efiring @tacaswell So should matplotlib be capitalized here?


Thank you for your help in keeping bug reports complete, targeted and descriptive.

Submitting a feature request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this section. I don't think it is very useful and has a lot of duplication with the previous section. I think we need to keep the contributing guideline short.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add back the sentence "You are also welcome to post feature requests or pull requests" here, and remove the section down of details about the feature requests.

@@ -14,8 +14,60 @@ Submitting a bug report

If you find a bug in the code or documentation, do not hesitate to submit a
ticket to the
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are
also welcome to post feature requests or pull requests.
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_.
**Expected outcome**

- [ ] A description of the expected outcome from the code snippet
- [ ] If this used to work in an earlier version of Matplotlib, please note where it used to work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"please note the version it used to work on?"

- [ ] If this is a regression (Used to work in an earlier version of Matplotlib), please
note where it used to work.

###Feature request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this section. We want to keep this as simple and short as possible.

@efiring
Copy link
Member
efiring commented Dec 31, 2016 via email

@@ -14,9 +14,34 @@ Submitting a bug report

If you find a bug in the code or documentation, do not hesitate to submit a
ticket to the
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are
also welcome to post feature requests or pull requests.
`Bug Tracker <https://github.com/matplotlib/matplotlib/issues>`_. You are also welcome to post feature requests or pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap at 80 here too.

@NelleV NelleV changed the title DOC: Add bug report reqs and template to contributing guide [MRG+1] DOC: Add bug report reqs and template to contributing guide Jan 1, 2017
@NelleV
Copy link
Member
NelleV commented Jan 1, 2017

LGTM 👍

@tacaswell tacaswell merged commit a430bf2 into matplotlib:master Jan 2, 2017
@QuLogic QuLogic changed the title [MRG+1] DOC: Add bug report reqs and template to contributing guide DOC: Add bug report reqs and template to contributing guide Jan 2, 2017
@QuLogic QuLogic added this to the v2.1 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0