LogFormatter bugfix, docs, support classic #7594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes matplotlib#7590. Classic style, with no minor tick labeling on a log axis, is supported via rcParams['_internal.classic'] LogFormatter changes are documented in api_changes and dflt_style_changes. An implicit boolean is made explicit in scale.py. A LogFormatter attribute that was sometimes, but not always, set by set_locs, but used only in __call__, is replaced by a local variable calculated in __call__. (set_locs doesn't have to be called prior to __call__, so this would have been a bug even if the attribute were always calculated by set_locs.)
QuLogic
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7590.
Classic style, with no minor tick labeling on a log axis,
is supported via rcParams['_internal.classic'].
LogFormatter changes are documented in api_changes and
dflt_style_changes.
An implicit boolean is made explicit in scale.py.
A LogFormatter attribute that was sometimes, but not always,
set by set_locs, but used only in call, is replaced by
a local variable calculated in call. (set_locs doesn't
have to be called prior to call, so this would have been
a bug even if the attribute were always calculated by set_locs.)