8000 Avoid division by zero if headlength=0 for quiver by rmjarvis · Pull Request #7525 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Avoid division by zero if headlength=0 for quiver #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2016
Merged

Avoid division by zero if headlength=0 for quiver #7525

merged 3 commits into from
Nov 28, 2016

Conversation

rmjarvis
Copy link
Contributor

I use quiver a lot with headless arrows to make whisker plots. But the code always outputs a division by zero warning, which I need to suppress. I don't think there is an open issue about this, but it was mentioned on list over four years ago.

Anyway, the fix is simple, so here it is.

@NelleV NelleV changed the title Avoid division by zero if headlength=0 for quiver [MRG+1] Avoid division by zero if headlength=0 for quiver Nov 28, 2016
NelleV
NelleV approved these changes Nov 28, 2016
View reviewed changes
Copy link
Member
@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
i don't know why appveyar is unhappy.

@rmjarvis
Copy link
Contributor Author

i don't know why appveyar is unhappy.

It appears to have been unhappy for a while now, so I suspect it is something on master unrelated to this PR. AFAICT, the last commit on master that passed AppVeyor was on Nov 19, when #7481 was merged. I don't think there is anything afterward that passes AppVeyor.

dopplershift
dopplershift approved these changes Nov 28, 2016
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@efiring efiring merged commit b9c3b64 into matplotlib:master Nov 28, 2016
@efiring
Copy link
Member
efiring commented Nov 28, 2016

Thank you, @rmjarvis.

efiring added a commit that referenced this pull request Nov 28, 2016
@efiring
Merge pull request #7525 from rmjarvis/quiver-nohead
ab65830 
[MRG+1] Avoid division by zero if headlength=0 for quiver
@efiring
Copy link
Member
efiring commented Nov 28, 2016

backported to 2.x as ab65830.

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Nov 28, 2016
@QuLogic QuLogic changed the title [MRG+1] Avoid division by zero if headlength=0 for quiver Avoid division by zero if headlength=0 for quiver Nov 28, 2016
@rmjarvis rmjarvis deleted the quiver-nohead branch November 28, 2016 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rmjarvis @efiring @NelleV @dopplershift @QuLogic
0