Set hexbin default linecolor to 'face' #7500
Conversation
There was a problem hiding this comment.
Hi @dstansby
The patch looks good overall, but there are pep8 incompatible changes added. Also, can you document those changes in the default change section
(doc/users/dflt_style_changes.rst) and what's new section (doc/users/whats_new/README.rst).
Thanks
| If 'none', draws the edges in the same color as the fill color. | ||
| This is the default, as it avoids unsightly unpainted pixels | ||
| between the hexagons. | ||
| edgecolors : {'face', 'none', *None*} or mpl color, optional, default is 'face' |
There was a problem hiding this comment.
This line is too long for pep8. It should be 79 char or less.
There was a problem hiding this comment.
I'm currently struggling to find a way to split it on to two lines without the 2nd line just becoming part of the paragraph underneath... Any ideas?
There was a problem hiding this comment.
This is an acceptable place to use \ to break the doc line.
There was a problem hiding this comment.
something like
edgecolors : {"face", "none", None, color}, optional, default: "face" would also have been acceptable.
|
|
||
| The default value of the ``linecolor`` kwarg for `~matplotlib.Axes.hexbin` has | ||
| changed from ``'none'`` to ``'face'``. If 'none' is now supplied, no line edges | ||
| are drawn around the hexagons. |
There was a problem hiding this comment.
This should note that the default behavior has not changed (just the meaning of 'none').
|
On 2016/11/23 10:34 AM, Thomas A Caswell wrote:
Or just leave out the "optional"? After all, specifying the default |
That's how Numpydoc already defines arguments that take a restricted set of inputs. |
|
Thanks for the patch @dstansby ! |
Fixes #7185