10000 MNT: use qt_compat for qt import in test_triage by tacaswell · Pull Request #7492 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: use qt_compat for qt import in test_triage #7492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2016
Merged

MNT: use qt_compat for qt import in test_triage #7492

merged 1 commit into from
Dec 13, 2016

Conversation

tacaswell
Copy link
Member

This enables use with both qt4 and qt5

@tacaswell
MNT: use qt_compat for qt import in test_triage
eec2e9b 
This enables use with both qt4 and qt5
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Nov 20, 2016
QuLogic
QuLogic approved these changes Dec 11, 2016
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@anntzer
Copy link
Contributor
anntzer commented Dec 13, 2016

LGTM.

@anntzer anntzer merged commit a5a1d21 into matplotlib:v2.x Dec 13, 2016
@anntzer
Copy link
Contributor
anntzer commented Dec 13, 2016

@tacaswell I'll let you backport if needed, I haven't really followed how this is happening in the rc period.

@tacaswell tacaswell deleted the enh_qt5_compat_test_triage branch December 13, 2016 13:29
@tacaswell
Copy link
Member Author

It was already targeted at 2.x

@tacaswell tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @anntzer @QuLogic
0