8000 MEP12 API examples by NelleV · Pull Request #7439 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MEP12 API examples #7439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2016
Merged

MEP12 API examples #7439

merged 2 commits into from
Nov 11, 2016

Conversation

NelleV
Copy link
Member
@NelleV NelleV commented Nov 11, 2016

MEP12-ifying API examples.

Related to #7206

@NelleV NelleV added this to the 2.1 (next point release) milestone Nov 11, 2016
QuLogic
QuLogic reviewed Nov 11, 2016
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several minor tweaks.

examples/api/bbox_intersect.py
Changing colors of lines intersecting a box
===========================================

The lines interescting the rectangle are colored in red, while the other one
Copy link
Member
@QuLogic QuLogic Nov 11, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interescting -> intersecting
other one -> others

examples/api/collections_demo.py
RegularPolyCollection with autoscaling.
'''
=========================================================
Line and Poly and RegularPoly Collection with autoscaling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line, Poly, and ...

examples/api/colorbar_basics.py
Colorbar
========

This example shows how to use colorbar by specify the mappable object (here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify -> specifying

examples/api/compound_path.py
Compound path
=============

Make a compound path -- in this case two simple polygons, a rectangle
and a triangle. Use CLOSEOPOLY and MOVETO for the different parts of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an existing typo here; should be CLOSEPOLY.

examples/api/custom_projection_example.py
Custom projection
=================

This example showcases the Hammer projection by alleviating many features of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think alleviating is the right verb here; not sure what it's trying to say (utilizing/using would fit without changing the sentence, but doesn't quite imply the same things.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one.

examples/api/sankey_demo_old.py
@@ -1,3 +1,11 @@
"""
========================
Yet another Sankey chart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart -> diagram

examples/api/sankey_demo_basics.py
"""Demonstrate the Sankey class by producing three basic diagrams.
"""
================
The Sankey class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50/50 on changing class to diagram here too.

examples/api/sankey_demo_rankine.py
"""Demonstrate the Sankey class with a practicle example of a Rankine power
"""
===================
Rankine power Cycle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle -> cycle

examples/api/sankey_demo_rankine.py
Rankine power Cycle
===================

Demonstrate the Sankey class with a practicle example of a Rankine power
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

practicle -> practical

examples/api/scatter_piecharts.py
@@ -1,5 +1,9 @@
"""
This example makes custom 'pie charts' as the markers for a scatter plotqu
====================================
Scatter plot with pie charts markers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

charts -> chart

@NelleV
Copy link
Member Author
NelleV commented Nov 11, 2016

Comments are addressed.

@tacaswell
Copy link
Member

appveyor failure is network related.

@tacaswell tacaswell merged commit a07af2d into matplotlib:master Nov 11, 2016
tacaswell added a commit that referenced this pull request Nov 11, 2016
@tacaswell
Merge pull request #7439 from NelleV/MEP12_api
a1b680b 
DOC: MEP12 API examples
@tacaswell
Copy link
Member

backported to v2.x as a1b680b

@tacaswell
Copy link
Member

Thanks @NelleV

@tacaswell tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Nov 11, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NelleV @tacaswell @QuLogic
0