8000 Do not rely on outer scope variables in `ImageComparisonTest.test.do_… by tacaswell · Pull Request #7425 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Do not rely on outer scope variables in `ImageComparisonTest.test.do_… #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Do not rely on outer scope variables in `ImageComparisonTest.test.do_… #7425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/matplotlib/testing/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def test(self):
@knownfailureif(
will_fail, fail_msg,
known_exception_class=ImageComparisonFailure)
def do_test():
def do_test(fignum, actual_fname, expected_fname):
figure = plt.figure(fignum)

if self._remove_text:
Expand All @@ -264,7 +264,7 @@ def do_test():
(self._freetype_version, ft2font.__freetype_version__))
raise

yield (do_test,)
yield do_test, fignum, actual_fname, expected_fname

def image_comparison(baseline_images=None, extensions=None, tol=0,
freetype_version=None, remove_text=False,
Expand Down
0