Fix Text layout cache lookup. #7420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though `Text._get_layout` takes a `renderer` parameter, the cache is looked up by the `self._renderer` attribute. If an alternate renderer is provided without changing any other properties, the cached layout from the previous renderer is returned. An alternate renderer is passed by `offsetbox.TextArea`, which, through its use in legends, causes the legend to shift slightly if figures are saved in different formats. Fixes matplotlib#6899.
Member
Author
|
A simpler fix is to have |
Member
Author
tacaswell
approved these changes
Nov 8, 2016
Member
|
I think this is better than updating the internal state. |
dopplershift
approved these changes
Nov 8, 2016
Contributor
There was a problem hiding this comment.
Looks good to me. I agree, passing through the API rather than modifying state is the way to go.
Member
|
@QuLogic thanks for fixing this, it really solves the problem with legends. Shame on me, I was close enough, but have not resolved the root issue T_T. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
Text._get_layouttakes arendererparameter, the cache is looked up by theself._rendererattribute. If an alternate renderer is provided without changing any other properties, the cached layout from the previous renderer is returned.An alternate renderer is passed by
offsetbox.TextArea, which, through its use in legends, causes the legend to shift slightly if figures are saved in different formats.Fixes #6899.