Add mplcursors to third-party packages. #7242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Oct 9, 2016
| mplcursors | ||
| ========== | ||
|
|
||
| `mplcursors <https://github.com/anntzer/mplcursors>` provides interactive |
There was a problem hiding this comment.
The trailing underscores are missing to turn this into a link. Also, why not link to RTD instead of GitHub?
There was a problem hiding this comment.
Thanks for the suggestion, fixed.
QuLogic
reviewed
Oct 9, 2016
| mplcursors | ||
| ========== | ||
|
|
||
| `mplcursors <https://mplcursors.readthedocs.io>_` provides interactive |
There was a problem hiding this comment.
The underscore goes outside the backtick.
Self-plug :-)
|
@anntzer Do you want to merge this as-is or wait for feedback from @joferkington ? |
|
Looks good to me! Greek free to merge the sections as well, it you'd like. Also, my apologies for being so out of the loop on things x lately. |
tacaswell
added a commit
that referenced
this pull request
Oct 9, 2016
DOC: Add mplcursors to third-party packages. Conflicts: doc/thirdpartypackages/index.rst This was moved from mpl_toolkits between these branches
|
backported to v1.5.3-doc as d134631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-plug :-)
@joferkington I would like to add a paragraph comparing the approaches of mpldatacursor and mplcursors, but I'd like to make sure that you agree with it. My feeling that mpldatacursor tries to provide as many customizations to the annotation as possible as kwargs in the call to
datacursor(), whereas I tried to makemplcursorsas minimal as possible, by letting instead the user hook into annotation-adding or removing events to customize the annotation as he sees fit.If we can agree on a comparison, then perhaps the two sections can be merged together, too.