Bugfix: enable picking of AsteriskCollection instances #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A primary use of these is in scatter, where they provide + and x symbols.
|
|
||
| def get_pickradius(self): | ||
| return self._pickradius | ||
|
|
There was a problem hiding this comment.
Noticing that this, Line and Axis all have a pickradius, maybe it belongs in Artist? Doesn't necessarily have to be done for this pull, but it seems like a useful refactoring to make.
Closed
magnunor
pushed a commit
to magnunor/matplotlib
that referenced
this pull request
Dec 5, 2013
Fixes matplotlib#70. EHN: to_image and to_ spectrum modified.
fariza
added a commit
to fariza/matplotlib
that referenced
this pull request
Sep 22, 2016
camera and camera routines doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A primary use of these is in scatter, where they provide + and x
symbols.
This fixes the problem reported here:
http://article.gmane.org/gmane.comp.python.matplotlib.devel/10069
The present commit is a fairly minimal solution to the problem; it makes the symbols pickable without breaking anything that I know of. It does change default behavior in that filled symbols from scatter (i.e., collections) now obey the pickradius--the cursor can be outside the symbol if self._pickradius or self._picker is non-zero. This could be addressed by setting different default _pickradius falues for different types of symbol; the filled types could default to zero, or at least to a smaller value than the default for unfilled types, and this can then be overridden by the picker kwarg if the user so chooses. I would be willing to add this change to the present branch, if others think it a good idea; I am neutral on doing it here and now.
Note that all this leaves an inconsistency between collections and Line2D objects. In the former, picking is based on the object path after stroking with a line of pickradius thickness; in the latter picking is based on datapoint locations and pickradius alone, with no account taken of the marker size. If any of this is to be smoothed out, I am inclined to do it in master, not v1.0.x.