DOC: OO interface in api and other examples #7067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rect = plt.Rectangle((-1, -1), 2, 2, facecolor="#aaaaaa") | ||
| plt.gca().add_patch(rect) | ||
| bbox = Bbox.from_bounds(-1, -1, 2, 2) | ||
| left, lower, width, height = (-1, -1, 2, 2) |
There was a problem hiding this comment.
I'd use bottom instead of lower.
4655ddd to
c57cf8a
Compare
NelleV
requested changes
Sep 19, 2016
| @@ -41,6 +42,6 @@ | |||
|
|
|||
| # The 'extend' kwarg does not work yet with a log scale. | |||
|
|
|||
| cbar = plt.colorbar() | |||
| cbar = fig.colorbar() | |||
There was a problem hiding this comment.
This line does not work. You need to pass the mappable (cs) to this function.
|
Hi @phobson |
The main thing here is that we have multiple axes and use the `fig.colorbar` method, specifying which mappables should be colorbar'd next to which Axes.
c57cf8a to
32301f0
Compare
|
@NelleV oops -- sorry for the delay. took care of that just now. |
NelleV
approved these changes
Oct 10, 2016
tacaswell
added a commit
that referenced
this pull request
Oct 11, 2016
DOC: OO interface in api and other examples
|
backported to v2.x as c729682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You mu
2E47
st change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more like #7066