8000 DOC change axhspan to numpydoc format by maluethi · Pull Request #7037 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC change axhspan to numpydoc format #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2016
Merged

DOC change axhspan to numpydoc format #7037

merged 2 commits into from
Sep 9, 2016

Conversation

maluethi
Copy link
Contributor
@maluethi maluethi commented Sep 5, 2016

Greetings from Rivo and Matthias at ASPP summer school.

@NelleV

@NelleV
Copy link
Member
NelleV commented Sep 5, 2016

This looks good! Thanks for the patch.
Cheers,
N

@NelleV
Copy link
Member
NelleV commented Sep 5, 2016

@tacaswell This PR is ready for review (and merge).


%(Polygon)s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been moved to the section "Other parameters".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the general line (i.e., kwargs), but not this substitution of all the keyword arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the list reference got lost during the conversion process. I fixed this in the new commit.

@QuLogic
Copy link
Member
QuLogic commented Sep 6, 2016

This PR should probably be coordinated with #7039 to get consistent prose.

@QuLogic
Copy link
Member
QuLogic commented Sep 6, 2016

Your commit is currently attributed to "maluethi". It is your choice to use a real name or not, of course, but I'm just making a note of it in case it was unintended.

@NelleV
Copy link
Member
NelleV commented Sep 7, 2016

The failing test seem unrelated so I think we are good to merge (thought it be good to relaunch the failing test on travis to make sure).
N

@QuLogic
Copy link
Member
QuLogic commented Sep 7, 2016

The two commits are attributed to two different names and two different email address, though they seem to refer to the same person; please confirm that is what you really want to do.

@maluethi
Copy link
Contributor Author
maluethi commented Sep 7, 2016

@QuLogic: This is fine by me.

@tacaswell tacaswell merged commit 7aa1db0 into matplotlib:master Sep 9, 2016
tacaswell added a commit that referenced this pull request Sep 9, 2016
DOC: change axhspan to numpydoc format
@tacaswell
Copy link
Member

backported to v2.x as 0234978

Thanks for your work!

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0