-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC change axhspan to numpydoc format #7037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good! Thanks for the patch. |
@tacaswell This PR is ready for review (and merge). |
|
||
%(Polygon)s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been moved to the section "Other parameters".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the general line (i.e., kwargs
), but not this substitution of all the keyword arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the list reference got lost during the conversion process. I fixed this in the new commit.
This PR should probably be coordinated with #7039 to get consistent prose. |
Your commit is currently attributed to "maluethi". It is your choice to use a real name or not, of course, but I'm just making a note of it in case it was unintended. |
…ing conversion to numpy doc.
The failing test seem unrelated so I think we are good to merge (thought it be good to relaunch the failing test on travis to make sure). |
The two commits are attributed to two different names and two different email address, though they seem to refer to the same person; please confirm that is what you really want to do. |
@QuLogic: This is fine by me. |
DOC: change axhspan to numpydoc format
backported to v2.x as 0234978 Thanks for your work! |
Greetings from Rivo and Matthias at ASPP summer school.
@NelleV