-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc v2 rel notes2 #7025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc v2 rel notes2 #7025
Conversation
ax.bar(range(5), [1, 4, 9, 16, 25], | ||
tick_label=tick_labels, align='center') | ||
ax.xaxis.set_tick_params(labelsize=20) | ||
ax.set_title('Участок под застройку с смайликам') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of the string is The construction site with an emoticon
(and there is an error in the end of the string, should be со смайликом
for singular or со смайликами
for plural). I think it was something else in the original meaning. I can make a translation for you if you wish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put 'plot with emoji' into google translate and that is what came out. Getting Cyrillic to render is a common question. The goal here was to show it works by default now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google translate made me laugh once again 😃
It will be Диаграмма с эмодзи
or Диаграмма со смайликами
.
(bottom, left) of the figure or axes. If the value is negative, | ||
however, the origin is from the (right, top) of the figure or axes, | ||
analogous to negative indexing of sequences. | ||
(bottom, left) of the figure or axes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think someone else noted earlier that this should be (left, bottom) to be consistent about the order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'bottom, left' sounds more natural to me and matches the (row, col) numpy indexing.
The inconsistency was with the now deleted 'right, top'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"bottom-left" is fine, but (bottom, left) looks like an argument specification, which should be an (x, y) pair.
@efiring I am currently re-writing the stuff in text_props.rst |
@@ -513,6 +555,8 @@ Legends | |||
|
|||
- The legend now has rounded corners by default. | |||
|
|||
- And a lighter border, I think? cf. #6770. (@QuLogic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> "The legend defaults now include rounded corners, a lighter boundary, and partially transparent boundary and background."
adds more international and math characters, but otherwise has the | ||
same appearance. Latin, Greek, Cyrillic, Armenian, Georgian, Hebrew, | ||
and Arabic are `all supported | ||
<http://dejavu-fonts.org/wiki/Main_Page>`__ (but right-to-left render |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
render -> rendering?
LGTM 👍 |
mpl.rcParams['hatch.linewidth'] = 1.0 / dpi # previous ps and Agg hatch linewidth | ||
|
||
|
||
There is no API level control of the hacth linewidth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hatch
demo(fig, {}, 'v2.0', 2) | ||
|
||
The size of the padding in the x and y directions is controlled by the | ||
``'axes.xmargin'`` and ``'axes.ymargin'`` rcParams respectively. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If" -> "Whether"
@efiring I am brain-dead for the night. You should have the power to push to my branch now if you want to take over on this. The things that are left to do:
I am happy if people keep pushing stuff to this branch / opening PRs against it or if we just merge this and iterate on it in a new PR. |
here's what I'd say about boxplots
|
Various edits to dflt_style_changes.rst
A few minor edits to text_props.rst
xytext=(0, -2), textcoords='offset pixels', | ||
bbox={'facecolor': 'w'}) | ||
|
||
ax.set_title('Диаграмма со смайликами') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments are very minor comments. |
@@ -606,6 +606,7 @@ Legends | |||
with mpl.rc_context(rc=rcparams): | |||
x = range(N) | |||
y = np.cumsum(np.random.randn(N) ) | |||
# unpack the single Line2D artist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a tab here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gah! I do not understand why emacs is putting tabs in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also surprising that the tests didn't pick this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe sphinx is still forgiving when parsing the rst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are built with Python 2, so any examples using tabs are probably not a big issue, plus this line is a comment anyway.
I don't think PEP8 is run on any inline examples.
DOC: explain changes to boxplot styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things.
|
||
import matplotlib as mpl | ||
import matplotlib.pyplot as plt | ||
import numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as np
; probably has no effect either way.
- `~matplotlib.artist.Artist.right_margin` | ||
- `~matplotlib.artist.Artist.margins` | ||
|
||
along with the complimentary ``get_*`` and ``set_*` D54 ` methods. When |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
complementary.
========================== ====================================================================================================================== | ||
alpha `float` | ||
backgroundcolor any matplotlib :ref:`color <colors>` | ||
bbox `~matplotlib.patches.Rectangle` prop dict plus key ``'pad'`` which is a pad in points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite know what this is trying to say, even in the original.
+---------------------+----------------------------------------------------+ | ||
| rcParam | usage | | ||
+=====================+====================================================+ | ||
| ``'font.family'`` | List of either names of font or ``{'cursive', | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"names of fonts" or "font names".
I will open a new PR soon addressing the remaining issues here. |
unless someone beats me to it ;) |
No description provided.