Check for fontproperties in figure.suptitle. #7019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_suptitle(): | ||
| fig = plt.figure() | ||
| ax = fig.add_subplot(1, 1, 1) | ||
| fig.suptitle('hello', color='r') | ||
| fig.suptitle('title', color='g', rotation='30') | ||
|
|
||
| from matplotlib.font_manager import FontProperties |
There was a problem hiding this comment.
Can you make this it's own test with the @cleanup decorator? Just checking that font size and weight are correct is probably enough for this test.
|
👍 |
Was previously applying defaults from rcParams when fontproperties was provided. This meant fontproperties got ignored.
1a6bdfa to
29f4679
Compare
|
Thanks for the patch! |
|
Needs backport. |
|
Happy to do that if desired. Which branch is it to target? |
tacaswell
pushed a commit
that referenced
this pull request
Sep 24, 2016
Check for fontproperties in figure.suptitle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued
2AE4
to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6996
Was previously applying defaults from rcParams when fontproperties was provided. This meant fontproperties got ignored.
Travis CI failed a seemingly unrelated test when I ran it on this change (https://travis-ci.org/dmkent/matplotlib/builds/156481606), will see what it thinks on the PR....