FIX: default color handling in bar3D #6990
Conversation
|
Is there any way of adding a test? |
| # no color specified | ||
| facecolors = [None] * len(x) | ||
| elif len(color) == len(x): | ||
| color = self._get_lines.get_next_color() |
There was a problem hiding this comment.
This is a string, generally, no? Which means it could match the next condition if there are 6 bars, or 1 bar, or whatever the length of the colour string is. I think that maybe isn't expected to happen?
There was a problem hiding this comment.
also, I don't think it would be self._get_lines. That would be for line plots.
|
I looked at modifying one of the existing tests, but they are testing with funny color vectors. |
If color not specified (default to `None`), get the next color from the axes color cycle. closes matplotlib#6989
49e3940 to
e0dbfdf
Compare
|
my comment wasn't addressed. It is pulling from the wrong color cycle. |
|
Pretty sure it should be |
|
@WeatherGod Sorry, I missed that. I think you commented after I checked, but before I pushed the change. |
Follow up to matplotlib#6990
If color not specified (default to
None), get the next color from theaxes color cycle.
closes #6989