8000 Fix Path deepcopy signature by has2k1 · Pull Request #6877 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix Path deepcopy signature #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Fix Path deepcopy signature #6877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Path deepcopy signature 
**Problem**

Path.__deepcopy__ does not accept a second(`memo`) parameter,
so the common usage of the `deepcopy` function fails.

**Solution**

Add second parameter. While at it, also take care of the case
of copying the `Path` without codes.
  • Loading branch information
@has2k1
has2k1 committed Aug 2, 2016
commit cfe45cdd19e6254631db9766e6f63a8aface742b
8 changes: 6 additions & 2 deletions lib/matplotlib/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,13 +297,17 @@ def __copy__(self):

copy = __copy__

def __deepcopy__(self):
def __deepcopy__(self, memo=None):
"""
Returns a deepcopy of the `Path`. The `Path` will not be
readonly, even if the source `Path` is.
"""
try:
codes = self.codes.copy()
except AttributeError:
codes = None
return self.__class__(
self.vertices.copy(), self.codes.copy(),
self.vertices.copy(), codes,
_interpolation_steps=self._interpolation_steps)

deepcopy = __deepcopy__
Expand Down
11 changes: 11 additions & 0 deletions lib/matplotlib/tests/test_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import (absolute_import, division, print_function,
unicode_literals)
import copy

import six

Expand Down Expand Up @@ -172,6 +173,16 @@ def test_path_to_polygons():
assert_array_equal(p.to_polygons(closed_only=False), [data])


def test_path_deepcopy():
# Should not raise any error
verts = [[0, 0], [1, 1]]
codes = [Path.MOVETO, Path.LINETO]
path1 = Path(verts)
path2 = Path(verts, codes)
copy.deepcopy(path1)
copy.deepcopy(path2)


if __name__ == '__main__':
import nose
nose.runmodule(argv=['-s', '--with-doctest'], exit=False)
0