10000 better freetype version checking by prhbrt · Pull Request #6803 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

better freetype version checking #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
better freetype version checking
  • Loading branch information
Herbert Kruitbosch committed Jul 20, 2016
commit 009ea6da8ed524d01fa53a387285d7b873f687b7
10 changes: 9 additions & 1 deletion lib/matplotlib/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,15 @@ def _init_tests():
warnings.warn(
"matplotlib is not built with the correct FreeType version to run "
"tests. Set local_freetype=True in setup.cfg and rebuild. "
"Expect many image comparison failures below.")
"Expect many image comparison failures below. "
"Expected freetype version {0}. "
"Found freetype version {1}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after period.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also not the case in the original, so I don't see the problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was not the case in the original? The original had spaces between sentences. This one is missing a space between two sentences.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, don't worry. We won't ask you to rebase/squash for this. It was only to clean out a messy revision history. Fixing one little thing doesn't need a rebase/squash in my opinion.

"Freetype build type is {2}local".format(
ft2font.__freetype_version__,
LOCAL_FREETYPE_VERSION,
"" if ft2font.__freetype_build_type__ == 'local' else "not "
)
)

try:
import nose
Expand Down
0