8000 TST: reset rcparams in animation smoke test by tacaswell · Pull Request #6767 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

TST: reset rcparams in animation smoke test #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2016
Merged

TST: reset rcparams in animation smoke test #6767

merged 1 commit into from
Sep 5, 2016

Conversation

tacaswell
Copy link
Member

Closes #6523

attn @cgohlke

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jul 16, 2016
@QuLogic
Copy link
Member
QuLogic commented Jul 16, 2016

An explanatory comment would not be unwelcome.

@tacaswell
Copy link
Member Author

@QuLogic fixed.

QuLogic
QuLogic reviewed Jul 17, 2016
View reviewed changes
lib/matplotlib/tests/test_animation.py Outdated
def check_save_animation(writer, extension='mp4'):
try:
# for ImageMagick the rcparams must be patched to account for
# 'concvert' being a built in MS tool, not the imagemagick
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert

@QuLogic
Copy link
Member
QuLogic commented Jul 17, 2016

I'd also mention that it's because cleanup reset the rcparams; sometimes people read the tests for ideas, and maybe we don't want them assuming this is necessary.

@tacaswell
Copy link
Member Author

This maybe revealing a much larger problem that this fix is sweeping under the rug. Some one needs to look into if mpl.style.use is also resetting this. I suspect in the animation module we need to reach in and touch the defaults.

@efiring efiring merged commit 0f3dbc4 into matplotlib:v2.x Sep 5, 2016
@tacaswell tacaswell deleted the tst_win_reg_fix branch September 5, 2016 19:57
@tacaswell tacaswell mentioned this pull request Sep 5, 2016
Closed
@tacaswell tacaswell mentioned this pull request Oct 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @QuLogic @efiring @story645
0