8000 Missing `cleanup` decorator in `test_subplots.test_exceptions` by Kojoley · Pull Request #6741 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Missing cleanup decorator in test_subplots.test_exceptions #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2016
Merged

Missing cleanup decorator in test_subplots.test_exceptions #6741

merged 3 commits into from
Jul 15, 2016

Conversation

Kojoley
Copy link
Member
@Kojoley Kojoley commented Jul 14, 2016 •
edited
Loading

pytest fails in test_subplots.test_subplots_offsettext because of missing cleanup, while nose is fine

@jenshnielsen
Copy link
Member

Looks good. It might resolve some of the intermittent failures on Nose too

There seems to be a typo in the test comments # the pount of this test is to ensure that this raises. can you change that to point

@jenshnielsen
Copy link
Member

@JanSchulz Any idea what happens to Appveyor here?

@Kojoley
Copy link
Member Author
Kojoley commented Jul 15, 2016

miktex has updated and something is wrong with them

@jankatins
Copy link
Contributor

Is this also from miktex?

======================================================================
ERROR: matplotlib.tests.test_dviread.test_dviread
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Miniconda-x64\envs\test-environment\lib\site-packages\nose\case.py", line 197, in runTest
    self.test(*self.arg)
  File "c:\projects\matplotlib\lib\matplotlib\tests\test_dviread.py", line 77, in test_dviread
    for page in dvi]
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 239, in __iter__
    have_page = self._read()
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 300, in _read
    self._dtable[byte](self, byte)
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 164, in wrapper
    return method(self, *[f(self, byte-min) for f in get_args])
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 447, in _fnt_def
    self._fnt_def_real(k, c, s, d, a, l)
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 458, in _fnt_def_real
    raise error_class("missing font metrics file: %s" % fontname)
OSError: missing font metrics file: cmr10

[from https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2039/job/jmlxickc9a0u510j]

I think the easiest would be to pin miktext to the old version for now... Will add a PR for that... and then try to understand whats going wrong here :-/

@jankatins jankatins mentioned this pull request Jul 15, 2016
Merged
@jankatins
Copy link
Contributor
jankatins commented Jul 15, 2016 •
edited
Loading

PW in #6744, will merge if that passes the appveyor tests

@jenshnielsen jenshnielsen merged commit d498f56 into matplotlib:master Jul 15, 2016
jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Jul 15, 2016
@jenshnielsen
Merge pull request matplotlib#6741 from Kojoley/missing-cleanup-decor…
74b634e 
…ator

Missing `cleanup` decorator in `test_subplots.test_exceptions`
@jenshnielsen
Copy link
Member

backported to 2.x via 74b634e

@jenshnielsen jenshnielsen mentioned this pull request Jul 15, 2016
Closed
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Jul 15, 2016
@Kojoley Kojoley mentioned this pull request Jul 16, 2016
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kojoley @jenshnielsen @jankatins @mdboom @QuLogic
0