-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Added a new example to create error boxes using a PatchCollection #6596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for doing this! Can you run this through a pep8 linter? closes #6593 |
No problem, I think that should be ok now? |
def makeErrorBoxes(xdata, ydata, xerror, yerror, fc='r', ec='None', alpha=0.5): | ||
''' | ||
Function to create error boxes | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget, did we want examples to have functions like this when it is just being called once? I thought it was only desirable to do for the examples to de-duplicate code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, in such a short example, there's not much benefit to this function, and there are more than enough comments to make it clear what all the code is doing.
Some suggestions (partially rendundant with other comments):
|
does this get backported anywhere? |
I think it should go into 2.x too |
Added a new example to create error boxes using a PatchCollection
backported to v2.x via 9ea7315 |
Adding a new example I first created here: http://stackoverflow.com/a/37856171/588071