WIP: Fix some animation confusion #6421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 the travis failure is due to a couple of lines being to long |
Instead of a hard-coded look for either instance types or strings, make it a property of the MovieWriter instances. Set the flag to true by default for the MovieFileWriters (which all seem to work fine) and make it false by default for MovieWriters (which are currently pipe-based and break). We can also eliminate looking at strings by doing the check after we create the instance of MovieWriter (if necessary).
This fixes part of matplotlib#6416 by resetting the 'savefig.bbox' rcParam if it is set to 'tight'.
255d8f6 to
229ddf6
Compare
|
Fixed (and rebased to squash the fix--hell will freeze over before a commit with my name only fixes pep8 😈 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6416.
It refactors and expands checking for the 'tight' figure bounding boxes that break piping image data to animation writers. First ,refactor things so that the writers can specify whether they handle changing figure sizes. By default
MovieWriter(i.e. pipe-based writers) sets the flag toFalse, whileMovieFileWritersets it toTrue; this seems to work appropriately for all of the various writers (on OSX at least, but I don't think this is a platform issue). It also adds handling of the'savefig.bbox'rcParam.The issue of what to do about being given a
MovieWriterinstance and kwargs for creating one remains TBD.