MNT: be explicitly strict in FunctionAnimation #6336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1210,6 +1213,9 @@ def _draw_frame(self, framedata): | |||
| # Call the func with framedata and args. If blitting is desired, | |||
| # func needs to return a sequence of any artists that were modified. | |||
| self._drawn_artists = self._func(framedata, *self._args) | |||
| if self._blit: | |||
| if self._blit and self._drawn_artists: | |||
| if self._drawn_artists is None: | |||
There was a problem hiding this comment.
This condition will never be True.
There was a problem hiding this comment.
Ah, did it one way, and then the other and forgot to remove the old version.
|
I think I am fine with this (modulo the comment I made), but I'd want @dopplershift's sign-off on this, too. We have been somewhat relaxed on the treatment of the returns from the user-supplied functions. |
If the user functions return None, raise RuntimeError. Suggested in matplotlib#6332
d42e2e8 to
65507a0
Compare
|
👍 from me--all we're doing is turning a confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user functions return None, raise RuntimeError.
Suggested in #6332
This was made unintentionally stricter 1.5.0 due to fixing the
animatedattribute usage.