Fix issue #4597. Make use of mkdtemp when creating temporary config directory. #6193
Conversation
|
This needs a rebase. The best thing about refactoring without changing behavior is you do not need to add more tests 😄 |
| tempdir = os.path.join(tempdir, 'matplotlib-%s' % getpass.getuser()) | ||
| os.environ['MPLCONFIGDIR'] = tempdir | ||
|
|
||
| # Set the environment variable for MPLCONFIGDIR with the tempdir |
There was a problem hiding this comment.
do not need the verbose comment.
|
@tacaswell I've rebased my branch to the tip of |
|
Are we sure this will still work on google app engine? This whole idea of On Mon, Mar 21, 2016 at 1:00 PM, Kanwar G notifications@github.com wrote:
|
|
Yes, https://github.com/matplotlib/matplotlib/pull/6193/files#diff-9ffb0d1db51a67ee4f37528e00715b3cR552 should take care of the GAE case. |
MNT: Make use of mkdtemp when creating temporary config directory. Fix #4597
|
I changed my mind about backporting this to 1.5.x, leaving it on 2.x + is fine. |
Original issue here.
I have made use of the appropriate prefix in mkdtemp that will also add username before appending the eight alphanumeric characters. For example, calling this function created the dir matplotlib-kanwar-8d6h5lxj inside my temp directory.
I am unsure as to how to add test cases for this since the change here was basically refactoring the code. Please suggest.