TST: raise ImageComparisonFailure on size mismatch #6191
Conversation
|
I agree this should raise an ImageComparisonError, but should we also fix the cleanup decorator so that it will always cleanup, no matter what exception passes through it? |
|
Looking at the log for the 3.6, I am no longer sure that the state was leaking... |
|
👍 |
I believe that's already the case. Do you have something that causes it to do otherwise? |
|
Are you asking me or @tacaswell? I was working under the assumption that his initial analysis was correct. That seem to now be in question. |
|
Yeah, I think I was wrong about it leaking, this just raises a better error now. |
Previously this would result in a ValueError
b67cd44 to
49d0184
Compare
|
commit message edited and force pushed. |
Previously this would result in a ValueError which would prevent proper
clean up of the tests and contaminate other tests.