8000 Optimize 3D display by AlexandreAbraham · Pull Request #6085 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Optimize 3D display #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Optimize 3D display #6085

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a4a8a86
Replace lists by numpy array in projection
AlexandreAbraham Feb 29, 2016
3d295af
Remove profiling code
AlexandreAbraham Feb 29, 2016
5239e1a
Vectorize output of proj_transform_vec
AlexandreAbraham Feb 29, 2016
7285fed
Reach vectorized projection functions directly
AlexandreAbraham Feb 29, 2016
328c2f4
Address comments
AlexandreAbraham Mar 2, 2016
a973da8
More fixes
AlexandreAbraham Mar 3, 2016
14853d0
Fix rotation of axes
AlexandreAbraham Mar 3, 2016
c4de047
Fix some failures
AlexandreAbraham Jun 8, 2016
6315961
Use a contiguous representation in memory and views for the segments
AlexandreAbraham Jun 8, 2016
bb948bb
Fix bug in PathPatch
AlexandreAbraham Sep 20, 2016
e6211bd
Fix vstack bug
AlexandreAbraham Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bug in PathPatch
  • Loading branch information
@AlexandreAbraham
AlexandreAbraham committed Sep 20, 2016
commit bb948bb619b990003670b1afc22c80045e6a14ac
3 changes: 2 additions & 1 deletion lib/mpl_toolkits/mplot3d/art3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def set_3d_properties(self, path, zs=0, zdir='z'):

def do_3d_projection(self, renderer):
# pad ones
s = np.vstack(self._segments3d, np.ones(self._segments3d.shape[1]))
s = np.vstack(self._segment3d, np.ones(self._segment3d.shape[1]))
Copy link
Member
@Kojoley Kojoley Sep 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np.vstack accepts only one argument.
You have here s = np.vstack([self._segment3d, np.ones(self._segment3d.shape[1])]) in a similar method above.

If do_3d_projection method is the same in multiple places except the single line I think it is better not to copy-paste it, but extract it to a general private method of Patch3D class.

vxyzis = proj3d.proj_transform_vec_clip(s, renderer.M)
self._path2d = mpath.Path(vxyzis[0:2].T, self._code3d)
# FIXME: coloring
Expand Down Expand Up @@ -349,6 +349,7 @@ def pathpatch_2d_to_3d(pathpatch, z=0, zdir='z'):
pathpatch.__class__ = PathPatch3D
pathpatch.set_3d_properties(mpath, z, zdir)


class Patch3DCollection(PatchCollection):
'''
A collection of 3D patches.
Expand Down
0