Cleanup clang warnings #6052
Merged
Cleanup clang warnings #6052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed these as well and was planning to fix them, but I think for 32/64-bit compatibility, you should use NumPy's macros instead of the hard-coded format specifiers. |
|
Looks good. I agree with @QuLogic: I didn't know about numpy's macros for this, but they seem like a good thing to use. |
|
@QuLogic Good point about the Numpy macros. I have updated to use those. |
01cdc7b to
ffc2f12
Compare
|
@jenshnielsen This needs a rebase. |
Should ensure correct formatting in both 32 and 64 bit
8b3fad5 to
3818675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of warnings that I am seeing with clang on OSX 10.11
@mdboom Some of these seems to be in the code from the new image rewrite