8000 STY: Fix grid and tick direction in bmh style. by QuLogic · Pull Request #6019 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

STY: Fix grid and tick direction in bmh style. #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2016
Merged

STY: Fix grid and tick direction in bmh style. #6019

merged 1 commit into from
Feb 19, 2016

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Feb 18, 2016

Fixes #5982.

I don't believe the other styles need any changes.

  • The dark background and grayscale styles are simply a colour change, so the ticks/grid/linewidth/etc. don't really need to change.
  • The fivethirtyeight style looks the same as before, except for the location of ticks.
  • The ggplot style also looks almost the same except for the edge around the scatter plot. However, I don't think ggplot actually uses a line around scatter markers, so it's more correct this way.

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Feb 18, 2016
tacaswell added a commit that referenced this pull request Feb 19, 2016
@tacaswell
Merge pull request #6019 from QuLogic/custom-style-update
ab191f8 
STY: Fix grid and tick direction in bmh style.
@tacaswell tacaswell merged commit ab191f8 into matplotlib:v2.x Feb 19, 2016
@QuLogic QuLogic deleted the custom-style-update branch February 19, 2016 02:31
@QuLogic QuLogic mentioned this pull request Feb 19, 2016
Closed
@mdboom
Copy link
Member
mdboom commented Feb 19, 2016

Thanks. This kind of work is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @mdboom @tacaswell
0