8000 Boxplot concept figure update by rasbt · Pull Request #5894 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Boxplot concept figure update #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenshnielsen merged 1 commit into from
Jan 24, 2016
Merged

Boxplot concept figure update #5894

jenshnielsen merged 1 commit into from
Jan 24, 2016

Conversation

@rasbt
Copy link
Contributor
@rasbt rasbt commented Jan 21, 2016

Fixed a typos according to #5889

@rasbt rasbt mentioned this pull request Jan 21, 2016
Closed
@tacaswell
Copy link
Member
tacaswell commented Jan 21, 2016

A tad concerned about the size increase.

@tacaswell tacaswell added this to the Critical bug fix release (1.5.2) milestone Jan 21, 2016
@WeatherGod
Copy link
Member
WeatherGod commented Jan 21, 2016

Yeah, we should make sure it looks ok in the docs.

@rasbt
Copy link
Contributor Author
rasbt commented Jan 21, 2016

I exported it as 300 ppi figure this time, but I can rescale it to the size of the "original" image. I think the previous format was fine!? Also, it would reduce the page load time and help keeping the matplotlib repo "slim." What do you think and suggest?

@tacaswell
Copy link
Member
tacaswell commented Jan 21, 2016

That sounds good. Please make use a force-push to make sure that the larger image never ends up in the history.

@rasbt
Copy link
Contributor Author
rasbt commented Jan 21, 2016

I think it should be fine now.

@WeatherGod
Copy link
Member
WeatherGod commented Jan 21, 2016

The copyright year is incorrect. Also, is this getting updated on wikimedia?

@rasbt
Copy link
Contributor Author
rasbt commented Jan 21, 2016

The copyright year is incorrect.

Right, should have changed the data after making these corrections.

Also, is this getting updated on wikimedia?

I haven't uploaded it to wikimedia

@rasbt
Copy link
Contributor Author
rasbt commented Jan 21, 2016

The date stamp should be okay now.

jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen
Merge pull request #5894 from rasbt/boxplot-figure
c228731 
Boxplot concept figure update
@jenshnielsen jenshnielsen merged commit c228731 into matplotlib:master Jan 24, 2016
jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen
Merge pull request #5894 from rasbt/boxplot-figure
1e55809 
Boxplot concept figure update
@jenshnielsen
Copy link
Member
jenshnielsen commented Jan 24, 2016

Backported to 1.5.1-doc as 1e55809

@jenshnielsen
Copy link
Member
jenshnielsen commented Jan 24, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v1.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@rasbt @tacaswell @WeatherGod @jenshnielsen @mdboom
0