8000 Support generative tests in @cleanup. by anntzer · Pull Request #5809 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Support generative tests in @cleanup. #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2016
+26 −12
Merged

Support generative tests in @cleanup. #5809

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f35177e
Support generative tests in @cleanup.
anntzer Jan 7, 2016
608855b
Temporary mark test_remove_shared_axes as failing.
anntzer Jan 7, 2016
e8bf90a
TST: fix broken test
tacaswell Jan 8, 2016
b441be2
cleanup should not always create a generator.
anntzer Jan 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: fix broken test 
One too many assertions

Closes #1
  • Loading branch information
@tacaswell @anntzer
tacaswell authored and anntzer committed Jan 8, 2016
commit e8bf90a6a6324e3be7ee294e50d83df67105479e
6 changes: 2 additions & 4 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
import warnings

import matplotlib
from matplotlib.testing.decorators import (
cleaup, image_comparison, knownfailureif)
from matplotlib.testing.decorators import image_comparison, cleanup
import matplotlib.pyplot as plt
import matplotlib.markers as mmarkers
from numpy.testing import assert_array_equal
Expand Down Expand Up @@ -4239,7 +4238,6 @@ def test_auto_numticks():


@cleanup
@knownfailureif(True)
def test_remove_shared_axes():
def _helper_x(ax):
ax2 = ax.twinx()
Expand Down Expand Up @@ -4280,7 +4278,7 @@ def _helper_y(ax):
orig_xlim = ax_lst[0][1].get_xlim()
ax.remove()
ax.set_xlim(0, 5)
assert assert_array_equal(ax_lst[0][1].get_xlim(), orig_xlim)
assert_array_equal(ax_lst[0][1].get_xlim(), orig_xlim)


@cleanup
Expand Down
0