8000 Correct regex in filterwarnings by jenshnielsen · Pull Request #5735 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Correct regex in filterwarnings #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2015
Merged

Correct regex in filterwarnings #5735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c9c55
Correct regex in filterwarnings
jenshnielsen Dec 23, 2015
6979fe5
Change error message to reflect the name of the method
jenshnielsen Dec 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correct regex in filterwarnings 
The method name has changed, also enable an assert which should have been enabled earlier
  • Loading branch information
@jenshnielsen
jenshnielsen committed Dec 23, 2015
commit d9c9c5540d7ecf51716971b24a6a42f0ae65e5d4
5 changes: 2 additions & 3 deletions lib/matplotlib/tests/test_subplots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,10 @@ def test_exceptions():
# the pount of this test is to ensure that this raises.
with warnings.catch_warnings():
warnings.filterwarnings('ignore',
message='.*sharex\ argument\ to\ subplots',
message='.*sharex\ argument\ to\ add_subplots',
category=UserWarning)
assert_raises(ValueError, plt.subplots, 2, 2, -1)
# uncomment this for 1.5
# assert_raises(ValueError, plt.subplots, 2, 2, 0)
assert_raises(ValueError, plt.subplots, 2, 2, 0)
assert_raises(ValueError, plt.subplots, 2, 2, 5)


Expand Down
0