Change default value for the number of columns when generating a legend from qt_editor #5713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd from the qt_editor, avoiding problems for large number of plots where no defaults are given for this value
|
This is a good enough solution here. It hard codes a 'magic' value, but is readable and works. Most places in mpl A some what less readable solution that hard-codes magic values in less places would be: legend_kwargs = {}
if axes.legend_ is not None:
old_legend = axes.get_legend()
draggable = old_legend._draggable is not None
legend_kwargs['ncol'] = old_legend._ncol
new_legend = axes.legend(**legend_kwargs) |
tacaswell
added a commit
that referenced
this pull request
Dec 23, 2015
FIX: default column number in qt edit box closes #5636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a correction related to the issue #5636 to make the legend generation working with more than two plots, due to the bad initialization of the number of columns. I hope without side effects...