10000 Reset the available animation movie writer on rcParam change by jankatins · Pull Request #5628 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reset the available animation movie writer on rcParam change #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2016
Merged

Reset the available animation movie writer on rcParam change #5628

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e3e2be9
Reset the available animation movie writer on rcParam change
jankatins Dec 6, 2015
6a01829
TST: Use a better command for annimation tests
jankatins Dec 9, 2015
6c6cf91
Fix: rerun check for imagemagick in isAvailable
jankatins Feb 7, 2016
96b439a
fix spelling
jankatins Feb 7, 2016
9b61b34
FIX: add debugging output when the MovieWriter fails
jankatins Feb 7, 2016
33f564a
Pep8 fixes
jankatins Feb 7, 2016
e783867
Add comment to explain the fix in ImageMagickBase
jankatins Feb 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: Use a better command for annimation tests 
python is blocking, leading to timeouts...
  • Loading branch information
@jankatins
jankatins committed Feb 6, 2016
commit 6a01829ac023c842b215c05da86a062f6c95d9b2
3 changes: 2 additions & 1 deletion lib/matplotlib/tests/test_animation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ def test_movie_writer_registry():
assert_false(animation.writers._dirty)
assert_false(animation.writers.is_available("ffmpeg"))
# something which is garanteered to be available in path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"garanteered"?

bin = u"python"
# and exits immediately
bin = u"true" if sys.platform != 'win32' else u"where"
mpl.rcParams['animation.ffmpeg_path'] = bin
assert_true(animation.writers._dirty)
animation.writers.list() # resets
Expand Down
0