Fix the resetting of color cycles #5536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
added a commit
that referenced
this pull request
Nov 24, 2015
Fix the resetting of color cycles
|
I take it that this will eventually get merged down to master and 2.x at some point, right? |
|
Yes, it already has. That happens semi-automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting v1.5.x as a fix, but will also need to go into master and v2.0. This fixes a regression introduced by me in 1.5.0.
In the process of creating the unit tests, I discovered another possible bug in the hatching validation. Haven't figured it out yet, but it will also need to be fixed.