10000 Fix #5524. Use finfo.max instead of np.inf by mdboom · Pull Request #5534 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix #5524. Use finfo.max instead of np.inf #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2015
Merged

Fix #5524. Use finfo.max instead of np.inf #5534

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9a4683
Fix #5524. Use finfo.max instead of np.inf
mdboom Nov 20, 2015
5428cea
Use vmin/vmax offset by eps
mdboom Nov 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use vmin/vmax offset by eps
  • Loading branch information
@mdboom
mdboom committed Nov 20, 2015
commit 5428cea4c1041b8a9ccad5c1b40186848ad0dedc
4 changes: 2 additions & 2 deletions lib/matplotlib/contour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,9 +1233,9 @@ def _process_levels(self):
# normed range:
finfo = np.finfo(float)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc, this can be a major time sink

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. In this case, I don't think it's in a hot path, though.

if self.extend in ('both', 'min'):
self.layers[0] = finfo.min
self.layers[0] = self.vmin - finfo.eps
if self.extend in ('both', 'max'):
self.layers[-1] = finfo.max
self.layers[-1] = self.vmax + finfo.eps

def _process_colors(self):
"""
Expand Down
0